Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: support table option: 'ENCRYPTION' #520

Merged
merged 2 commits into from
Aug 26, 2019
Merged

parser: support table option: 'ENCRYPTION' #520

merged 2 commits into from
Aug 26, 2019

Conversation

spongedu
Copy link
Contributor

What problem does this PR solve?

For #475 , Support table option ENCRYPTION.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

N / A

Side effects

N / A

Related changes

N / A

@codecov
Copy link

codecov bot commented Aug 25, 2019 •
edited
Loading

Codecov Report

Merging #520 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage    71.7%   71.67%   -0.03%     
==========================================
  Files          32       32              
  Lines        7760     7752       -8     
==========================================
- Hits         5564     5556       -8     
  Misses       1671     1671              
  Partials      525      525
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
ast/ddl.go 80.22% <100%> (-0.1%) ⬇️
misc.go 96.49% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c25d7a...55bcbe8. Read the comment docs.

kennytm
kennytm reviewed Aug 25, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Aug 25, 2019
@zier-one zier-one mentioned this pull request Aug 26, 2019
Closed
58 tasks
zier-one
zier-one previously approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 26, 2019
@zier-one zier-one merged commit d66a73d into pingcap:master Aug 26, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@spongedu
parser: support table option: 'ENCRYPTION' (pingcap#520)
723e5cb
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@spongedu
parser: support table option: 'ENCRYPTION' (pingcap#520)
d3a382c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spongedu @kennytm @zier-one @you06